fix: use accessors instead of direct access to now-private structures #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @philomory and thank you for your interest and work to produce this PR! Unfortunately, the creator of this repo stopped maintaining it a while ago and I stopped using CUPS altogether even before that event occurred. Regardless I was looking at 2.3.3 documentation, patch notes and code commits but I couldn't find any information about dropping _IPP_PRIVATE_STRUCTURES define. Do you care to share any relevant information? |
|
There wasn't a lot of fanfare about it, but you can see that it was removed in this commit in 2018: OpenPrinting/cups@0fb02fb (So, as it turns out, this wasn't a change in 2.3.3, but actually in 2.3rc1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with CUPS 1.6, various structs such as
ipp_attribute_twere made private, with the intent that their members be accessed via accessor functions such asippNextAttribute()andippGetGroupTag(). In CUPS 2.3.3, the_IPP_PRIVATE_STRUCTURESdefine was removed entirely, so the only means to read these structs became using the accessor methods.This patch simply replaces direct member access with the use of the relevant accessor methods, so that the notifier can be compiled with for use with CUPS 2.3.3+.